Messages in this thread | | | Date | Thu, 21 Jun 2018 13:30:50 -0500 | From | Moritz Fischer <> | Subject | Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct |
| |
Hi David,
On Wed, Jun 20, 2018 at 07:37:50AM +0900, David Miller wrote: > From: Florian Fainelli <f.fainelli@gmail.com> > Date: Tue, 19 Jun 2018 10:13:55 -0700 > > > How could padding be inserted given than all of the structure members > > are naturally aligned (all u32 type). Compiler bug? > > Agreed, this looks completely unnecessary. > > __packed should only be used when absolutely necessary because using > it generates less efficient code on some architectures.
Thanks for your input, will fix with the whole series when I submit it.
- Moritz
| |