lkml.org 
[lkml]   [2018]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ceph: use ktime_get_real_seconds()
> >
> > Use ktime_get_real_seconds() as get_seconds() is deprecated.
> >
> > Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> > ---
> > net/ceph/auth_x.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/net/ceph/auth_x.c b/net/ceph/auth_x.c
> > index 2f4a1ba..99561c2 100644
> > --- a/net/ceph/auth_x.c
> > +++ b/net/ceph/auth_x.c
> > @@ -154,7 +154,7 @@ static int process_one_ticket(struct ceph_auth_client *ac,
> > void **ptp;
> > struct ceph_crypto_key new_session_key = { 0 };
> > struct ceph_buffer *new_ticket_blob;
> > - unsigned long new_expires, new_renew_after;
> > + u32 new_expires, new_renew_after;
> > u64 new_secret_id;
> > int ret;
> >
> > @@ -191,9 +191,9 @@ static int process_one_ticket(struct ceph_auth_client *ac,
> >
> > ceph_decode_timespec(&validity, dp);
> > dp += sizeof(struct ceph_timespec);
> > - new_expires = get_seconds() + validity.tv_sec;
> > + new_expires = (u32)ktime_get_real_seconds() + validity.tv_sec;
>
> Why the change to u32 and this cast? If the type has to change,
> wouldn't time64_t make more sense? ktime_get_real_seconds() returns
> time64_t, after all.
>

Right. I'll drop the cast and send out V2.

- Allen

\
 
 \ /
  Last update: 2018-06-20 16:43    [W:1.128 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site