lkml.org 
[lkml]   [2018]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 3/6] dt-bindings: xilinx_dma: add required xlnx,lengthregwidth property
    Date

    > -----Original Message-----
    > From: dmaengine-owner@vger.kernel.org [mailto:dmaengine-
    > owner@vger.kernel.org] On Behalf Of Andrea Merello
    > Sent: Wednesday, June 20, 2018 2:07 PM
    > To: vkoul@kernel.org; dan.j.williams@intel.com; Michal Simek
    > <michals@xilinx.com>; Appana Durga Kedareswara Rao
    > <appanad@xilinx.com>; dmaengine@vger.kernel.org
    > Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
    > Andrea Merello <andrea.merello@gmail.com>
    > Subject: [PATCH 3/6] dt-bindings: xilinx_dma: add required
    > xlnx,lengthregwidth property

    dt-bindings: dmaengine: xilinx_dma

    Please also include DT folks.
    >
    > The width of the "length register" cannot be autodetected, and it is now
    > specified with a DT property. Add DOC for it.
    >
    > Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
    > ---
    > Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > index a2b8bfaec43c..acecdc5d8d47 100644
    > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > @@ -36,6 +36,8 @@ Required properties:
    >
    > Required properties for VDMA:
    > - xlnx,num-fstores: Should be the number of framebuffers as configured in
    > h/w.
    > +Required properties for AXI DMA:
    > +- xlnx,lengthregwidth: Should be the width of the length register as
    > configured in h/w.

    One suggestion to be inline with IP property naming we can rename
    this prop to "xlnx,sg-length-width"? Please take a look at Xilinx tree
    we have this feature added in the master branch. It would be good
    to consolidate both implementations and upstream. Let me know
    if there are any followup queries.

    >
    > Optional properties:
    > - xlnx,include-sg: Tells configured for Scatter-mode in
    > --
    > 2.17.1
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe dmaengine" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html

    \
     
     \ /
      Last update: 2018-06-20 15:43    [W:3.117 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site