lkml.org 
[lkml]   [2018]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/12] spi: spi-fsl-dspi: Drop unreachable else if statement
From
Date


On 2018-06-20 09:34, Esben Haabendal wrote:
> From: Esben Haabendal <eha@deif.com>
>
> The if statement just above this if/else statement triggers on the same
> condition, and then invalidates it.
>
> Signed-off-by: Esben Haabendal <eha@deif.com>
> Cc: Martin Hundebøll <martin@geanix.com>

For the entire series:
Acked-by: Martin Hundebøll <martin@geanix.com>

> ---
> drivers/spi/spi-fsl-dspi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 0630962ce442..3ca9b9608801 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -593,8 +593,7 @@ static int dspi_eoq_write(struct fsl_dspi *dspi)
> dspi_pushr |= SPI_PUSHR_EOQ;
> if ((dspi->cs_change) && (!dspi->len))
> dspi_pushr &= ~SPI_PUSHR_CONT;
> - } else if (tx_word && (dspi->len == 1))
> - dspi_pushr |= SPI_PUSHR_EOQ;
> + }
>
> regmap_write(dspi->regmap, SPI_PUSHR, dspi_pushr);
>
>

--
Kind regards,
Martin Hundebøll
Embedded Linux Consultant

+45 61 65 54 61
martin@geanix.com

Geanix IVS
DK39600706

\
 
 \ /
  Last update: 2018-06-20 10:51    [W:0.157 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site