Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 20 Jun 2018 09:39:21 +0200 | Subject | Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: clean up timestamp handling |
| |
On Tue, Jun 19, 2018 at 11:52 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote: > On 06-19 21:11, Arnd Bergmann wrote: >> On Tue, Jun 19, 2018 at 7:14 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote: >> > On 06-19 17:58, Arnd Bergmann wrote:
>> Here, setting a timestamp before 1970 or after 2514 will get wrapped >> around in unpatched kernels, but will be clamped to the minimum >> and maximum times after the patch. >> >> It is extremely rare for correct code to need timestamps outside of that >> range, but it is also trivial to trigger that with a manual 'touch' command >> from user space. >> >> If the change is a problem, I can resend the patch without that one >> line change. >> > > I think you should keep the change, but incrment OCFS2_LVB_VERSION.
Won't that cause additional incompatibilities? I don't know how this macro gets used, but normally we don't use version numbers in kernel interfaces if that prevents us from using old user space code with newer kernels.
Arnd
| |