Messages in this thread | | | Date | Thu, 21 Jun 2018 10:30:28 +0900 (KST) | Subject | Re: [PATCH net] net: mscc: fix the injection header | From | David Miller <> |
| |
From: Antoine Tenart <antoine.tenart@bootlin.com> Date: Wed, 20 Jun 2018 10:50:46 +0200
> When injecting frames in the Ocelot switch driver an injection header > (IFH) should be used to configure various parameters related to a given > frame, such as the port onto which the frame should be departed or its > vlan id. Other parameters in the switch configuration can led to an > injected frame being sent without an IFH but this led to various issues > as the per-frame parameters are then not used. This is especially true > when using multiple ports for injection. > > The IFH was injected with the wrong endianness which led to the switch > not taking it into account as the IFH_INJ_BYPASS bit was then unset. > (The bit tells the switch to use the IFH over its internal > configuration). This patch fixes it. > > In addition to the endianness fix, the IFH is also fixed. As it was > (unwillingly) unused, some of its fields were not configured the right > way. > > Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Applied, thank you.
| |