Messages in this thread | | | Subject | Re: [SIL2review] [PATCH] media: tc358743: release device_node in tc358743_probe_of() | From | Alexey Khoroshilov <> | Date | Sun, 3 Jun 2018 01:11:49 +0300 |
| |
On 26.05.2018 17:38, Nicholas Mc Guire wrote: > On Sat, May 26, 2018 at 12:54:00AM +0300, Alexey Khoroshilov wrote: >> of_graph_get_next_endpoint() returns device_node with refcnt increased, >> but these is no of_node_put() for it. > > I think this is correct - but would it not be simpler to do > > endpoint = v4l2_fwnode_endpoint_alloc_parse(of_fwnode_handle(ep)); > of_node_put(ep); > if (IS_ERR(endpoint)) { > .... > > As the of_node_put(np) actually is unconditional anyway I think this > should be semantically equivalent.
You are right. But the same is true for v4l2_fwnode_endpoint_free(endpoint); that is already correctly handled by the driver. So, I have preferred to follow the same pattern.
> >> >> The patch adds one on error and normal paths. >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > Reviewed-by: Nicholas Mc Guire <der.herr@hofr.at>
Thank you, Alexey
| |