Messages in this thread | | | Date | Fri, 1 Jun 2018 22:41:31 -0700 | From | Davidlohr Bueso <> | Subject | Re: [PATCH 2/5] lib/rhashtable: guarantee initial hashtable allocation |
| |
On Sat, 02 Jun 2018, Herbert Xu wrote: >> tbl = bucket_table_alloc(ht, size, GFP_KERNEL); >> - if (tbl == NULL) >> - return -ENOMEM; >> + if (unlikely(tbl == NULL)) { >> + size = min_t(u16, ht->p.min_size, HASH_MIN_SIZE); > >You mean max_t?
Not really. I considered some of the users to set quite a large min_size (such as 1024 buckets). The min() makes sense to me in that it's the smallest possible value. If memory later becomes available and the hashtable is resized to a more appropriate value, couldn't any issues regarding collisions not be dealt with organically? And we've agreed that allocating a tiny table is the least of our problems.
Thanks, Davidlohr
| |