Messages in this thread | | | Subject | Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask() | From | Paolo Bonzini <> | Date | Tue, 19 Jun 2018 19:13:41 +0200 |
| |
On 19/06/2018 19:08, Nick Desaulniers wrote: >> This one really makes the code uglier though, so I'm not really inclined >> to applying the patch. > Note that of the three variables (w, u, x), only u is used later on. > What about declaring them as negated with the cast, that way there's > no cast in a ternary?
I still find it inferior, but I guess it's at least acceptable. I prefer not_{x,w,u} though. :)
Paolo
| |