lkml.org 
[lkml]   [2018]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults
From
Date
Hi Thomas,

On 6/19/2018 9:53 AM, Thomas Gleixner wrote:
> On Tue, 19 Jun 2018, Reinette Chatre wrote:
>> On 6/19/2018 5:31 AM, Thomas Gleixner wrote:
>>> On Thu, 7 Jun 2018, Reinette Chatre wrote:
>>>> +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r)
>>>> +{
>>>> + unsigned long *val = (unsigned long *)_val;
>>>
>>> I'm a bit worried about the u32 to unsigned long case here. I know that
>>> cbm_len cannot exceed 32, but still. At least it wants a comment.
>>
>> Will do.
>>
>> I am planning to add the following to the next version.
>
> Don't bother. I'm picking up the delta as I'm halfways through the whole
> thing by now and if there is no major update pending from your side, I'm
> going to merge it as is.

Thank you very much. I do not have anything else pending from my side at
this time.

Reinette

\
 
 \ /
  Last update: 2018-06-19 19:07    [W:0.269 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site