Messages in this thread | | | From | David Laight <> | Subject | RE: [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions | Date | Tue, 19 Jun 2018 11:27:54 +0000 |
| |
From: Mike Galbraith > Sent: 17 June 2018 14:39 ... > > > Is dinky patchlet suggesting cryptomgr is being naughty? ... > > diff --git a/arch/x86/crypto/aegis128-aesni-asm.S b/arch/x86/crypto/aegis128-aesni-asm.S > > index 9254e0b6cc06..717bf0776421 100644 > > --- a/arch/x86/crypto/aegis128-aesni-asm.S > > +++ b/arch/x86/crypto/aegis128-aesni-asm.S > > @@ -535,6 +535,7 @@ ENTRY(crypto_aegis128_aesni_enc_tail) > > movdqu STATE3, 0x40(STATEP) > > > > FRAME_END > > + ret > > ENDPROC(crypto_aegis128_aesni_enc_tail) ...
How much of the rest of the associated crypyo changes were actually tested? I can't image the code DTRT without the 'ret'.
David
| |