lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectApplied "ASoC: codecs: PCM1789: unconditionally flush work" to the asoc tree
    Date
    The patch

    ASoC: codecs: PCM1789: unconditionally flush work

    has been applied to the asoc tree at

    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

    All being well this means that it will be integrated into the linux-next
    tree (usually sometime in the next 24 hours) and sent to Linus during
    the next merge window (or sooner if it is a bug fix), however if
    problems are discovered then the patch may be dropped or reverted.

    You may get further e-mails resulting from automated or manual testing
    and review of the tree, please engage with people reporting problems and
    send followup patches addressing any issues that are reported if needed.

    If any updates are required or you are submitting further changes they
    should be sent as incremental updates against current git, existing
    patches will not be replaced.

    Please add any relevant lists and maintainers to the CCs when replying
    to this mail.

    Thanks,
    Mark

    From a7dc662c6a7b9209df600c64b16d33d72dbf56b1 Mon Sep 17 00:00:00 2001
    From: Stefan Agner <stefan@agner.ch>
    Date: Sun, 17 Jun 2018 15:45:29 +0200
    Subject: [PATCH] ASoC: codecs: PCM1789: unconditionally flush work

    Work is guaranteed to be initialized on exit. Drop the unnecessary
    if statement and always call flush_work.

    This fixes a warning seen with clang:
    sound/soc/codecs/pcm1789.c:265:13: warning: address of 'priv->work' will
    always evaluate to 'true' [-Wpointer-bool-conversion]
    if (&priv->work)
    ~~ ~~~~~~^~~~

    Signed-off-by: Stefan Agner <stefan@agner.ch>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    ---
    sound/soc/codecs/pcm1789.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/pcm1789.c b/sound/soc/codecs/pcm1789.c
    index 21f15219b3ad..8df6447c76a6 100644
    --- a/sound/soc/codecs/pcm1789.c
    +++ b/sound/soc/codecs/pcm1789.c
    @@ -262,8 +262,7 @@ int pcm1789_common_exit(struct device *dev)
    {
    struct pcm1789_private *priv = dev_get_drvdata(dev);

    - if (&priv->work)
    - flush_work(&priv->work);
    + flush_work(&priv->work);

    return 0;
    }
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-06-18 14:05    [W:6.774 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site