lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] sound/usb/line6: fix some styling issues
On Mon, 18 Jun 2018 12:29:36 +0200,
Roman Sommer wrote:
>
> CC: Jaroslav Kysela <perex@perex.cz>
> CC: Takashi Iwai <tiwai@suse.com>
> CC: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> CC: "Hans P. Möller Ebner" <hmoller@uc.cl>
> CC: Kees Cook <keescook@chromium.org>
> CC: Kate Stewart <kstewart@linuxfoundation.org>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: "Fabián Inostroza" <soulsonceonfire@gmail.com>
> CC: Bhumika Goyal <bhumirks@gmail.com>
> CC: Philippe Ombredanne <pombredanne@nexb.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: alsa-devel@alsa-project.org
> CC: linux-kernel@vger.kernel.org
>
>
> This patchseries addresses some styling issues in sound/usb/line6 found by
> checkpatch.

Are you working further on this driver to fix any real bugs (or
implements something new), or it's an action "just because checkpatch
tells"? I'd take such cleanup patches only for the former case.


thanks,

Takashi


>
> Roman Sommer (3):
> sound/line6: checkpatch: fix block comment style
> sound/line6: unsigned -> unsigned int
> sound/line6: add newline after declarations
>
> sound/usb/line6/capture.c | 20 ++++-----
> sound/usb/line6/driver.c | 110 ++++++++++++++++++++++-----------------------
> sound/usb/line6/driver.h | 33 +++++++-------
> sound/usb/line6/midi.c | 24 +++++-----
> sound/usb/line6/midibuf.c | 6 +--
> sound/usb/line6/pcm.c | 26 +++++------
> sound/usb/line6/pcm.h | 74 +++++++++++++++---------------
> sound/usb/line6/playback.c | 36 ++++++++-------
> sound/usb/line6/pod.c | 60 ++++++++++++-------------
> sound/usb/line6/podhd.c | 8 ++--
> sound/usb/line6/toneport.c | 30 ++++++-------
> sound/usb/line6/variax.c | 40 ++++++++---------
> 12 files changed, 235 insertions(+), 232 deletions(-)
>
> --
> 2.7.4
>
>

\
 
 \ /
  Last update: 2018-06-18 12:41    [W:2.339 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site