lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] printk: make sure to print log on console.
On (06/18/18 15:15), Sergey Senozhatsky wrote:
>
> On (06/01/18 14:26), Maninder Singh wrote:
> >
> > Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

OK, we probably need v3 after all.

I think this

- if (suppress_message_printing(msg->level)) {
+ if (msg->flags & LOG_NOCONS) {

must be changed to

- if (suppress_message_printing(msg->level)) {
+ if (!ignore_loglevel && (msg->flags & LOG_NOCONS)) {


`ignore_loglevel' is a module param and can change any time via
/sys/module/printk/parameters/ignore_loglevel
we need to respect its value.

-ss

\
 
 \ /
  Last update: 2018-06-18 08:23    [W:0.086 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site