Messages in this thread | | | Date | Mon, 18 Jun 2018 15:23:06 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH v2] printk: make sure to print log on console. |
| |
On (06/18/18 15:15), Sergey Senozhatsky wrote: > > On (06/01/18 14:26), Maninder Singh wrote: > > > > Signed-off-by: Vaneet Narang <v.narang@samsung.com> > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
OK, we probably need v3 after all.
I think this
- if (suppress_message_printing(msg->level)) { + if (msg->flags & LOG_NOCONS) {
must be changed to
- if (suppress_message_printing(msg->level)) { + if (!ignore_loglevel && (msg->flags & LOG_NOCONS)) {
`ignore_loglevel' is a module param and can change any time via /sys/module/printk/parameters/ignore_loglevel we need to respect its value.
-ss
| |