lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 061/279] net: hns: Avoid action name truncation
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: dann frazier <dann.frazier@canonical.com>

    [ Upstream commit f4ea89110df237da6fbcaab76af431e85f07d904 ]

    When longer interface names are used, the action names exposed in
    /proc/interrupts and /proc/irq/* maybe truncated. For example, when
    using the predictable name algorithm in systemd on a HiSilicon D05,
    I see:

    ubuntu@d05-3:~$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'
    enahisic2i0-tx0
    enahisic2i0-tx1
    [...]
    enahisic2i0-tx8
    enahisic2i0-tx9
    enahisic2i0-tx1
    enahisic2i0-tx1
    enahisic2i0-tx1
    enahisic2i0-tx1
    enahisic2i0-tx1
    enahisic2i0-tx1

    Increase the max ring name length to allow for an interface name
    of IFNAMSIZE. After this change, I now see:

    $ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'
    enahisic2i0-tx0
    enahisic2i0-tx1
    enahisic2i0-tx2
    [...]
    enahisic2i0-tx8
    enahisic2i0-tx9
    enahisic2i0-tx10
    enahisic2i0-tx11
    enahisic2i0-tx12
    enahisic2i0-tx13
    enahisic2i0-tx14
    enahisic2i0-tx15

    Signed-off-by: dann frazier <dann.frazier@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/hisilicon/hns/hnae.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
    +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
    @@ -87,7 +87,7 @@ do { \

    #define HNAE_AE_REGISTER 0x1

    -#define RCB_RING_NAME_LEN 16
    +#define RCB_RING_NAME_LEN (IFNAMSIZ + 4)

    #define HNAE_LOWEST_LATENCY_COAL_PARAM 30
    #define HNAE_LOW_LATENCY_COAL_PARAM 80

    \
     
     \ /
      Last update: 2018-06-18 11:59    [W:4.476 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site