lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 041/189] vfs: Undo an overly zealous MS_RDONLY -> SB_RDONLY conversion
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Howells <dhowells@redhat.com>

    [ Upstream commit a9e5b73288cf1595ac2e05cf1acd1924ceea05fa ]

    In do_mount() when the MS_* flags are being converted to MNT_* flags,
    MS_RDONLY got accidentally convered to SB_RDONLY.

    Undo this change.

    Fixes: e462ec50cb5f ("VFS: Differentiate mount flags (MS_*) from internal superblock flags")
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/namespace.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/namespace.c
    +++ b/fs/namespace.c
    @@ -2810,7 +2810,7 @@ long do_mount(const char *dev_name, cons
    mnt_flags |= MNT_NODIRATIME;
    if (flags & MS_STRICTATIME)
    mnt_flags &= ~(MNT_RELATIME | MNT_NOATIME);
    - if (flags & SB_RDONLY)
    + if (flags & MS_RDONLY)
    mnt_flags |= MNT_READONLY;

    /* The default atime for remount is preservation */

    \
     
     \ /
      Last update: 2018-06-18 11:09    [W:2.554 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site