lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 144/189] ixgbe: return error on unsupported SFP module when resetting
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Emil Tantilov <emil.s.tantilov@intel.com>

    [ Upstream commit bbb2707623f3ccc48695da2433f06d7c38193451 ]

    Add check for unsupported module and return the error code.
    This fixes a Coverity hit due to unused return status from setup_sfp.

    Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
    Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
    +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
    @@ -3413,6 +3413,9 @@ static s32 ixgbe_reset_hw_X550em(struct
    hw->phy.sfp_setup_needed = false;
    }

    + if (status == IXGBE_ERR_SFP_NOT_SUPPORTED)
    + return status;
    +
    /* Reset PHY */
    if (!hw->phy.reset_disable && hw->phy.ops.reset)
    hw->phy.ops.reset(hw);

    \
     
     \ /
      Last update: 2018-06-18 10:51    [W:4.087 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site