lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 165/189] mtd: Fix comparison in map_word_andequal()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Hutchings <ben@decadent.org.uk>

    [ Upstream commit ea739a287f4f16d6250bea779a1026ead79695f2 ]

    Commit 9e343e87d2c4 ("mtd: cfi: convert inline functions to macros")
    changed map_word_andequal() into a macro, but also changed the right
    hand side of the comparison from val3 to val2. Change it back to use
    val3 on the right hand side.

    Thankfully this did not cause a regression because all callers
    currently pass the same argument for val2 and val3.

    Fixes: 9e343e87d2c4 ("mtd: cfi: convert inline functions to macros")
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/linux/mtd/map.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/linux/mtd/map.h
    +++ b/include/linux/mtd/map.h
    @@ -312,7 +312,7 @@ void map_destroy(struct mtd_info *mtd);
    ({ \
    int i, ret = 1; \
    for (i = 0; i < map_words(map); i++) { \
    - if (((val1).x[i] & (val2).x[i]) != (val2).x[i]) { \
    + if (((val1).x[i] & (val2).x[i]) != (val3).x[i]) { \
    ret = 0; \
    break; \
    } \

    \
     
     \ /
      Last update: 2018-06-18 10:48    [W:4.498 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site