lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 192/279] drm/omap: silence unititialized variable warning
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 4a9fbfcab19d3f71ad2bf0bcb653c4ee84e69c7f ]

    Smatch complains that "area_free" could be used without being
    initialized. This code is several years old and premusably works fine
    so this can't be a very serious bug. But it's easy enough to silence
    the warning. If "area_free" is false at the end of the function then
    we return -ENOMEM.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20180418142937.GA13828@mwanda
    Signed-off-by: Sean Paul <seanpaul@chromium.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/omapdrm/tcm-sita.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/omapdrm/tcm-sita.c
    +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c
    @@ -90,7 +90,7 @@ static int l2r_t2b(uint16_t w, uint16_t
    {
    int i;
    unsigned long index;
    - bool area_free;
    + bool area_free = false;
    unsigned long slots_per_band = PAGE_SIZE / slot_bytes;
    unsigned long bit_offset = (offset > 0) ? offset / slot_bytes : 0;
    unsigned long curr_bit = bit_offset;

    \
     
     \ /
      Last update: 2018-06-18 10:24    [W:5.666 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site