Messages in this thread | | | From | gengdongjiu <> | Subject | 答复: [PATCH v2] usb: xhci: remove the code b uild warning | Date | Sat, 16 Jun 2018 09:08:23 +0000 |
| |
> On Wed, Jun 06, 2018 at 10:36:59PM +0800, Dongjiu Geng wrote: > > Initialize the 'err' variate to remove the build warning, the warning > > is shown as below: > > > > drivers/usb/host/xhci-tegra.c: In function 'tegra_xusb_mbox_thread': > > drivers/usb/host/xhci-tegra.c:552:6: warning: 'err' may be used > > uninitialized in this function [-Wuninitialized] > > drivers/usb/host/xhci-tegra.c:482:6: note: 'err' was declared here > > > > Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> > > Acked-by: Thierry Reding <treding@nvidia.com> > > --- > > How to reproduce: > > 1. make defconfig ARCH=arm > > 2. make -j100 CROSS_COMPILE=arm-linux-gnueabi- ARCH=arm > > > > Then you can see below warnings: > > drivers/usb/host/xhci-tegra.c: In function 'tegra_xusb_mbox_thread': > > drivers/usb/host/xhci-tegra.c:552:6: warning: 'err' may be used > > uninitialized in this function [-Wuninitialized] > > drivers/usb/host/xhci-tegra.c:482:6: note: 'err' was declared here > > What changed from v1? Always put that below the --- line. > > Please fix up and resend a v3.
Thanks, I justly add "Acked-by: Thierry Reding <treding@nvidia.com>" in the V2 compared with v1 Anyway I will put that below and resend a v3.
> > thanks, > > greg k-h
| |