lkml.org 
[lkml]   [2018]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] nds32: Fix build error caused by configuration flag rename
James Hogan <jhogan@kernel.org> 於 2018年6月14日 週四 下午10:29寫道:
>
> From: Guenter Roeck <linux@roeck-us.net>
>
> Fix build error on nds32 due to the merge of commit e3d5980568f ("lib:
> Rename compiler intrinsic selects to GENERIC_LIB_*") during the 4.18
> merge window which renames Kconfig symbols. This had raced with commit
> aeaa7af744fa ("nds32: lib: To use generic lib instead of libgcc to
> prevent the symbol undefined issue.") merged late in the 4.17 cycle,
> which added selects to nds32 using the original Kconfig symbol names.
>
> When they came together in merge commit 763f96944c95 ("Merge tag
> 'mips_4.18' of
> git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux") this resulted
> in the following build errors:
>
> nds32le-linux-ld: kernel/time/timekeeping.o: in function `timekeeping_init':
> timekeeping.c:(.init.text+0x140): undefined reference to `__ashldi3'
> nds32le-linux-ld: timekeeping.c:(.init.text+0x144): undefined reference to `__ashldi3'
> nds32le-linux-ld: timekeeping.c:(.init.text+0x17e): undefined reference to `__lshrdi3'
> nds32le-linux-ld: timekeeping.c:(.init.text+0x182): undefined reference to `__lshrdi3'
> nds32le-linux-ld: drivers/clocksource/mmio.o: in function `clocksource_mmio_init':
> mmio.c:(.init.text+0x54): undefined reference to `__lshrdi3'
> nds32le-linux-ld: mmio.c:(.init.text+0x58): undefined reference to `__lshrdi3'
>
> Rename all 6 selects in nds32 and adjust the ordering accordingly to be
> alphabetical.
>
> Fixes: 763f96944c95 ("Merge tag 'mips_4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> [jhogan@kernel.org: Rename all 6 symbols, sort, update commit message]
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> Cc: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Palmer Dabbelt <palmer@sifive.com>
> ---
> Changes in v2:
> - Rename all 6 symbols, not just the 3 that caused build failures.
> - Sort selects.
> - Update commit message.

Thank you James and Guenter.
Should I pick it in my tree? It will be ok to put in your tree. :)

Acked-by: Greentime Hu <greentime@andestech.com>

\
 
 \ /
  Last update: 2018-06-15 08:14    [W:0.031 / U:41.596 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site