lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1] bitmap: Drop unnecessary 0 check for u32 array operations
On Thu, May 31, 2018 at 5:47 PM, Yury Norov <ynorov@caviumnetworks.com> wrote:
> On Thu, May 31, 2018 at 04:19:14PM +0300, Andy Shevchenko wrote:
>> The nbits == 0 is safe to be supplied to the function body, so,
>> remove unnecessary checks in bitmap_to_arr32() and bitmap_from_arr32().

>> +void bitmap_from_arr32(unsigned long *bitmap, const u32 *buf, unsigned int nbits)
>
> This line is 81 characters length, and it will trigger checkpatch warning.
> (But I'm OK with it.)

I really don't care about ) at the end potentially not visible on the
screen (who is using nice old hardware terminals? :-) ).

> Acked-by: Yury Norov <ynorov@caviumnetworks.com>

Thanks.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-06-14 14:03    [W:0.031 / U:28.300 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site