Messages in this thread | | | Subject | Re: [PATCH 2/2] gpio: davinci: Do not assume continuous IRQ numbering | From | Keerthy <> | Date | Thu, 14 Jun 2018 14:21:14 +0530 |
| |
On Thursday 14 June 2018 01:59 PM, Linus Walleij wrote: > On Wed, Jun 6, 2018 at 11:18 AM, Keerthy <j-keerthy@ti.com> wrote: > >> Currently the driver assumes that the interrupts are continuous >> and does platform_get_irq only once and assumes the rest are continuous, >> instead call platform_get_irq for all the interrupts and store them >> in an array for later use. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> > > Hm! Thierry has recently submitted patches to make it easier for chips with > banked IRQs to use the GPIOLIB_IRQCHIP. > > Please look at the code in gpio/gpio-tegra186.c and see if you can use > his approach. > > As you can see this chip is using gpiochip_irq_map/unmap in its > domain, and manipulates struct gpio_irq_chip directly. > > I think the idea is to make it possible to use GPIOLIB_IRQCHIP > for banked IRQs but the infrastructure is not yet inside the gpiolib > so it is a bit taped on the side right now.
Okay. I will take a look at that. The key issue that this patch addresses is that currently driver only calls platform_get_irq once and assumes the rest are continuous which is wrong hence the key issue addressed with this patch is to call platform_get_irq for each interrupt.
The version 4 is here:
https://patchwork.kernel.org/patch/10461537/
I will try to follow up with generic gpiochip_irq_map/unmap once i get that working. Hope that is okay?
> > Yours, > Linus Walleij >
| |