lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] soc: qcom: Remove depends on ARCH_QCOM
On Thu, Jun 14, 2018 at 12:08:10PM +0530, Vivek Gautam wrote:
> On Thu, Jun 14, 2018 at 12:05 PM, Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
> > On Wed, Jun 13, 2018 at 6:24 PM, Niklas Cassel <niklas.cassel@linaro.org> wrote:
> >> Since commit cab673583d96 ("soc: Unconditionally include qcom Makefile"),
> >> we unconditionally include the soc/qcom/Makefile.
> >>
> >> This opens up the possibility to compile test the code even when
> >> building for other architectures.
> >
> > Why do we want to do this when all of it is qcom specific?
> > Besides, wouldn't this increase the binary size for other platforms.

To be able to compile test drivers that select some of these Kconfigs,
even when building for other architectures.

The binary size shouldn't increase if they don't enable these Kconfigs.

>
> Sorry, my bad. Send the message without completing.
>
> Besides above points, the COMPILE_TEST flag should allow you
> to compile test all of these drivers. If COMPILE_TEST is missing
> in some of the configs, we should try adding that.
> Or, is there anything that I am missing here for the intention of this patch?

That is another alternative.
So either make sure that all these Kconfigs
have "depends on ARCH_QCOM || COMPILE_TEST",
or
remove ARCH_QCOM from these Kconfigs.

A third, and perhaps best alternative is to do like
drivers/soc/mediatek/Kconfig

menu "MediaTek SoC drivers"
depends on ARCH_MEDIATEK || COMPILE_TEST

Make sure that our root menu entry depends on ARCH_QCOM || COMPILE_TEST,
that way we could remove ARCH_QCOM for all Kconfigs.

Thoughts?


Regards,
Niklas

\
 
 \ /
  Last update: 2018-06-14 10:32    [W:0.034 / U:0.412 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site