lkml.org 
[lkml]   [2018]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 12/27] venus: hfi_parser: add common capability parser
Hi Stanimir,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17 next-20180613]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Stanimir-Varbanov/Venus-updates/20180613-233225
base: git://linuxtv.org/media_tree.git master
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc

Note: the linux-review/Stanimir-Varbanov/Venus-updates/20180613-233225 HEAD 14ff811c9a95add10f8f724b37cc0dbbce8d6f33 builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

drivers/media/platform/qcom/venus/hfi_parser.c: In function 'parse_alloc_mode':
>> drivers/media/platform/qcom/venus/hfi_parser.c:77:44: error: 'inst' undeclared (first use in this function); did you mean 'insl'?
if (*type == HFI_BUFFER_MODE_DYNAMIC && inst)
^~~~
insl
drivers/media/platform/qcom/venus/hfi_parser.c:77:44: note: each undeclared identifier is reported only once for each function it appears in

vim +77 drivers/media/platform/qcom/venus/hfi_parser.c

61
62 static void
63 parse_alloc_mode(struct venus_core *core, u32 codecs, u32 domain, void *data)
64 {
65 struct hfi_buffer_alloc_mode_supported *mode = data;
66 u32 num_entries = mode->num_entries;
67 u32 *type;
68
69 if (num_entries > MAX_ALLOC_MODE_ENTRIES)
70 return;
71
72 type = mode->data;
73
74 while (num_entries--) {
75 if (mode->buffer_type == HFI_BUFFER_OUTPUT ||
76 mode->buffer_type == HFI_BUFFER_OUTPUT2) {
> 77 if (*type == HFI_BUFFER_MODE_DYNAMIC && inst)
78 inst->cap_bufs_mode_dynamic = true;
79
80 for_each_codec(core->caps, ARRAY_SIZE(core->caps),
81 codecs, domain, fill_buf_mode, type, 1);
82 }
83
84 type++;
85 }
86 }
87

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-06-14 05:09    [W:0.055 / U:3.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site