Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex | Date | Wed, 13 Jun 2018 21:00:19 +0200 |
| |
Rob Herring <robh@kernel.org> writes:
> On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: >> This adds a binding for the Marvell PXA audio complex, available in >> pxa2xx and pxa3xx variants. >> +Required properties: >> + - compatible: "marvell,pxa2xx-ac97" > > Don't use wildcards in compatible strings. Though this is so old... Yes, I could use pxa270-ac97.
>> + - reset-gpio: gpio used for AC97 reset, refer to gpio.txt > reset-gpios Right, I'm on it.
>> + status = "okay"; > > Don't show status in examples. Sure.
Cheers.
-- Robert
| |