lkml.org 
[lkml]   [2018]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 2/2] gpio: davinci: Do not assume continuous IRQ numbering
From
Date


On 06/12/2018 10:40 PM, Keerthy wrote:
> Currently the driver assumes that the interrupts are continuous
> and does platform_get_irq only once and assumes the rest are continuous,
> instead call platform_get_irq for all the interrupts and store them
> in an array for later use.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> Tested for GPIO Interrupts on da850-lcdk board.
>
> Changes in v4:
>
> * Corrected the gpio offset calculation from irq number
> using the lookup.
>
> Changes in v3:
>
> * Changed irqs type from unsigned to int
>
> Changes in v2:
>
> * Extended the logic of using saved IRQs to unbanked IRQs
> as per Grygorii's suggestion.
>
> drivers/gpio/gpio-davinci.c | 63 ++++++++++++++++++++----------
> include/linux/platform_data/gpio-davinci.h | 3 +-
> 2 files changed, 44 insertions(+), 22 deletions(-)
>

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

--
regards,
-grygorii

\
 
 \ /
  Last update: 2018-06-13 19:25    [W:0.045 / U:16.980 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site