lkml.org 
[lkml]   [2018]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/3] scsi: check for equality of result byte values
Date
On Wed, 2018-06-13 at 09:53 +0200, Johannes Thumshirn wrote:
> if ((cmd->result == (DID_OK << 16)
> - || status_byte(cmd->result) &
> - CHECK_CONDITION)) {
> + || status_byte(cmd->result) == CHECK_CONDITION)) {

A minor comment: the preferred coding style is to place "||" at the end of the
previous line.

> - if ((driver_byte(the_result) & DRIVER_SENSE) == 0) {
> + if (driver_byte(the_result) == DRIVER_SENSE) {

This change looks wrong to me.

Bart.


\
 
 \ /
  Last update: 2018-06-13 15:09    [W:0.048 / U:24.184 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site