Messages in this thread | | | Date | Wed, 13 Jun 2018 04:59:29 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 3/3] scsi: don't add scsi command result bytes |
| |
On Wed, Jun 13, 2018 at 09:53:49AM +0200, Johannes Thumshirn wrote: > Some drivers are ADDing the scsi command's result bytes instead of > ORing them. > > While this can produce correct results it has unexpected side effects. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> - cmd->result = (DID_OK << 16) + (l & STATUS_MASK); > + cmd->result = DID_OK << 16 | (l & STATUS_MASK);
Although I would have keep the braces around the shift operators to stick closer to the original code. But the code should be fine even without them.
| |