Messages in this thread | | | Date | Tue, 12 Jun 2018 14:28:32 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v7 2/4] random: Return nbytes filled from hw RNG |
| |
On Tue, 12 Jun 2018 11:39:56 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Tue, Jun 12, 2018 at 3:39 AM, Tobin C. Harding <me@tobin.cc> wrote: > > Currently the function get_random_bytes_arch() has return value 'void'. > > If the hw RNG fails we currently fall back to using get_random_bytes(). > > This defeats the purpose of requesting random material from the hw RNG > > in the first place. > > > - int chunk = min(nbytes, (int)sizeof(unsigned long)); > > + int chunk = min_t(int, left, (int)sizeof(unsigned long)); > > Isn't this (int) implied when you use min_t(int, ...) ? >
I would say so...
#define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <)
-- Steve
| |