Messages in this thread | | | Date | Tue, 12 Jun 2018 14:30:36 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH V6] powercap/drivers/idle_injection: Add an idle injection framework |
| |
On Tue, Jun 12, 2018 at 02:00:11PM +0200, Daniel Lezcano wrote: > +static void __idle_injection_wakeup(struct idle_injection_device *ii_dev) > +{ > + struct idle_injection_thread *iit; > + struct cpumask tmp; > + unsigned int cpu; > + > + cpumask_and(&tmp, ii_dev->cpumask, cpu_online_mask);
You should not be having a cpumask on the stack. Those things can be ginormous.
| |