Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 12 Jun 2018 11:35:17 +0300 | Subject | Re: [PATCH] drivers/of: Add devm_of_iomap() |
| |
On Tue, Jun 12, 2018 at 3:01 AM, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > There are still quite a few cases where a device might want to get to a > different node of the device-tree, obtain the resources and map them. > > Drivers doing that currently open code the whole thing, which is error > proe.
prone
> > We have of_iomap() and of_io_request_and_map() but they both have shortcomings, > such as not returning the size of the resource found (which can be necessary) > and not being "managed". > > This adds a devm_of_iomap() that provides all of these and should probably > replace uses of the above in most drivers.
It feels like a wrong approach. Can OF graph help here? Would it be better approach?
-- With Best Regards, Andy Shevchenko
| |