lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] dmaengine: rcar-dmac: don't use DMAC error interrupt
Date

Hi Geert

Thank you for your light speed review :)

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Current rcar-dmac is using DMAC error interrupt which will handle all
> > channel's error. But in this design, error handling itself will be
> > issue if user want to use virtualization, multi OS, etc.
> > This patch removes current DMAC error interrupt handling, and handle it
> > on each channel interrupt handler.
> >
> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Who wrote this patch, you or Magnus? Or is this a joint effort?

Original was Magnus, and I updated it.
I think I need to add such things.

> > --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> > +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> > @@ -35,9 +35,8 @@ Required Properties:
> >
> > - interrupts: interrupt specifiers for the DMAC, one for each entry in
> > interrupt-names.
> > -- interrupt-names: one entry for the error interrupt, named "error", plus one
> > - entry per channel, named "ch%u", where %u is the channel number ranging from
> > - zero to the number of channels minus one.
> > +- interrupt-names: one entry per channel, named "ch%u", where %u is the
> > + channel number ranging from zero to the number of channels minus one.
>
> DT bindings describe hardware, not software policy.
> So IMHO the error interrupt must not be removed from the bindings (and
> from the DTS and example).

IC

> The rest looks good to me (but I haven't tested it), so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks. Will post v2 tomorrow

Best regards
---
Kuninori Morimoto

\
 
 \ /
  Last update: 2018-06-12 10:14    [W:0.029 / U:1.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site