lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 3/4] powerpc/lib: implement strlen() in assembly
Date
Christophe LEROY <christophe.leroy@c-s.fr> writes:

> Le 12/06/2018 à 16:53, Segher Boessenkool a écrit :
>> On Tue, Jun 12, 2018 at 09:14:53AM +0000, Christophe Leroy wrote:
>>> ---
>>> Not tested on PPC64.
>>
>> It won't be acceptable until that happens. It also is likely quite bad
>> performance on all 64-bit CPUs from the last fifteen years or so. Or you
>> did nothing to prove otherwise, at least.
>
> Will it be as bad as the generic implementation which does it byte per
> byte ?
>
> I don't have any 64 bits target, can someone test it using the test app
> I have added in selftests ?

I /can/ but I won't have time this week.

> Or should I just leave it as is for 64 bits and just do the
> implementation for 32 bits until someone wants to try and do it for PPC64 ?

That's probably best yeah.

cheers

\
 
 \ /
  Last update: 2018-06-13 05:59    [W:1.041 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site