lkml.org 
[lkml]   [2018]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 02/13] input: add MT_TOOL_DIAL
    On Thu, Jun 07, 2018 at 09:54:37AM +0200, Benjamin Tissoires wrote:
    > A dial is a tool you place on a multitouch surface which reports its
    > orientation or a relative angle of rotation when rotating its knob.
    >
    > Some examples are the Dell Totem (on the Canvas 27"), the Microsoft Dial,
    > or the Griffin Powermate, though the later can't be put on a touch surface.
    >
    > We give some extra space to account for other types of fingers if we need
    > (MT_TOOL_THUMB)
    >
    > Slightly change the documentation to not make it mandatory to update each
    > MT_TOOL we add.
    >
    > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    >
    > ---
    >
    > new in v2 (extracted from previous series in its own patch)
    > ---
    > Documentation/input/multi-touch-protocol.rst | 12 ++++++------
    > include/uapi/linux/input-event-codes.h | 3 ++-

    Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

    (modulo input-event-codes.h vs input.h)

    > 2 files changed, 8 insertions(+), 7 deletions(-)
    >
    > diff --git a/Documentation/input/multi-touch-protocol.rst b/Documentation/input/multi-touch-protocol.rst
    > index b51751a0cd5d..6be70342e709 100644
    > --- a/Documentation/input/multi-touch-protocol.rst
    > +++ b/Documentation/input/multi-touch-protocol.rst
    > @@ -310,12 +310,12 @@ ABS_MT_TOOL_Y
    > ABS_MT_TOOL_TYPE
    > The type of approaching tool. A lot of kernel drivers cannot distinguish
    > between different tool types, such as a finger or a pen. In such cases, the
    > - event should be omitted. The protocol currently supports MT_TOOL_FINGER,
    > - MT_TOOL_PEN, and MT_TOOL_PALM [#f2]_. For type B devices, this event is
    > - handled by input core; drivers should instead use
    > - input_mt_report_slot_state(). A contact's ABS_MT_TOOL_TYPE may change over
    > - time while still touching the device, because the firmware may not be able
    > - to determine which tool is being used when it first appears.
    > + event should be omitted. The protocol currently mainly supports
    > + MT_TOOL_FINGER, MT_TOOL_PEN, and MT_TOOL_PALM [#f2]_.
    > + For type B devices, this event is handled by input core; drivers should
    > + instead use input_mt_report_slot_state(). A contact's ABS_MT_TOOL_TYPE may
    > + change over time while still touching the device, because the firmware may
    > + not be able to determine which tool is being used when it first appears.
    >
    > ABS_MT_BLOB_ID
    > The BLOB_ID groups several packets together into one arbitrarily shaped
    > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
    > index e8841cdb1ebd..a8d55f3909d3 100644
    > --- a/include/uapi/linux/input-event-codes.h
    > +++ b/include/uapi/linux/input-event-codes.h
    > @@ -854,6 +854,7 @@
    > #define MT_TOOL_FINGER 0
    > #define MT_TOOL_PEN 1
    > #define MT_TOOL_PALM 2
    > -#define MT_TOOL_MAX 2
    > +#define MT_TOOL_DIAL 10
    > +#define MT_TOOL_MAX 10
    >
    > #endif
    > --
    > 2.14.3
    >

    --
    Dmitry

    \
     
     \ /
      Last update: 2018-06-11 19:19    [W:9.148 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site