Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 11 Jun 2018 10:46:59 +0200 | Subject | Re: [PATCH] microblaze: Remove architecture heart beat code |
| |
On Mon, Jun 11, 2018 at 8:09 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> There is no reason to keep this gpio based code in architecture. Use > ledtrig-heartbeat.c instead which is much more flexible then this > ancient code. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Maybe the arch maintainers will complain that the corresponding new heartbeat code is not put in place in the same patch, but I think the change is so much overdue that I don't see why they can't do that themselves if they have interest in it.
BTW: m68k has the same kind of luggage, in the middle of it timekeeping code: arch/m68k/kernel/time.c
Yours, Linus Walleij
| |