Messages in this thread | | | Date | Sat, 2 Jun 2018 00:28:59 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 06/18] rhashtable: simplify nested_table_alloc() and rht_bucket_nested_insert() |
| |
On Fri, Jun 01, 2018 at 02:44:09PM +1000, NeilBrown wrote: > Now that we don't use the hash value or shift in nested_table_alloc() > there is room for simplification. > We only need to pass a "is this a leaf" flag to nested_table_alloc(), > and don't need to track as much information in > rht_bucket_nested_insert(). > > Note there is another minor cleanup in nested_table_alloc() here. > The number of elements in a page of "union nested_tables" is most naturally > > PAGE_SIZE / sizeof(ntbl[0]) > > The previous code had > > PAGE_SIZE / sizeof(ntbl[0].bucket) > > which happens to be the correct value only because the bucket uses all > the space in the union. > > Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au> -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |