Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 1 Jun 2018 14:34:23 +0300 | Subject | Re: [PATCH v2 21/21] sparc64: use match_string() helper |
| |
On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote: > match_string() returns the index of an array for a matching string, > which can be used instead of open coded variant.
> @@ -512,10 +512,9 @@ static unsigned long __init mdesc_cpu_hwcap_list(void) > break; > } > }
It seems previous loop also can be replaced.
> - for (i = 0; i < ARRAY_SIZE(crypto_hwcaps); i++) { > - if (!strcmp(prop, crypto_hwcaps[i])) > - caps |= HWCAP_SPARC_CRYPTO; > - } > + i = match_string(crypto_hwcaps, ARRAY_SIZE(crypto_hwcaps), prop); > + if (i >= 0) > + caps |= HWCAP_SPARC_CRYPTO; > > plen = strlen(prop) + 1; > prop += plen; > -- > 1.7.12.4 >
-- With Best Regards, Andy Shevchenko
| |