Messages in this thread | | | Subject | Re: [PATCH 03/11] spi: Add a driver for the Freescale/NXP QuadSPI controller | From | Frieder Schrempf <> | Date | Fri, 1 Jun 2018 11:14:52 +0200 |
| |
Hi Yogesh,
On 30.05.2018 16:24, Boris Brezillon wrote: > Hi Yogesh, > > On Wed, 30 May 2018 13:50:51 +0000 > Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote: > >> Hi Frieder, >> >> Thanks for migrating the fsl-quadspi.c driver on the new SPI >> framework. This patch is using dynamic LUT approach to create the LUT >> at run time instead of fixed static LUT as being used in current >> driver present at mtd/spi-nor/fsl-quadspi.c. I have pushed the >> changes for dynamic LUT on mtd/spi-nor/fsl-quadspi.c and v10 has been >> in review stage. >> >> Request you to please add 'signed-off' mentioned in those patches in >> this patch, patchwork link is >> https://patchwork.ozlabs.org/patch/896534/
So for reasons already given by Boris, I won't add your S-o-b tags. But I can add your name (and that of Suresh Gupta?) to the file header and as MODULE_AUTHOR in the next version.
Regards,
Frieder
> > First, I'd like to state that this work has not been based on your > dynamic LUT code, and I actually asked you to adapt your code to match > the way we were handling it in the new driver (which at that time was > still under development). Then, even if you want to be cited as one of > the author of the new code, SoB tag is not the right way to do it (see > [1] for an explanation on when SoB should be added). Instead, you > should add your name in the copyright header and maybe be add a > MODULE_AUTHOR(): > > /* > * Copyright ... > * ... > * Authors: > * ... > * Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> > */ > > ... > > MODULE_AUTHOR("Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>"); > > Regards, > > Boris > > [1]https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L429 >
| |