Messages in this thread | | | From | Salvatore Mesoraca <> | Date | Tue, 8 May 2018 12:32:49 +0200 | Subject | Re: [PATCH v2] net: dsa: drop some VLAs in switch.c |
| |
2018-05-08 11:39 GMT+02:00 David Laight <David.Laight@aculab.com>: > From: Salvatore Mesoraca >> Sent: 07 May 2018 20:03 > ... >> This optimization will save us an allocation when number of ports is >> less than 32 or 64 (depending on arch). >> IMHO it's useful, if you consider that, right now, DSA works only with >> 12-ports switches. > > Why not just error out if the number of ports is greater than the compile-time > limit? > > Worry about dynamic allocation if you need a lot more than 64 ports.
v1 has been NAK-ed by maintainers because they don't want limits on how many ports a switch can have.
Salvatore
| |