lkml.org 
[lkml]   [2018]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] clk: qcom: Add support for RCG to register for DFS
Hi Taniya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v4.17-rc3 next-20180503]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Taniya-Das/clk-qcom-Add-support-for-RCG-to-register-for-DFS/20180503-220112
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next

smatch warnings:
drivers/clk/qcom/clk-rcg2.c:820 clk_parent_index_pre_div_and_mode() warn: signedness bug returning '(-22)'

# https://github.com/0day-ci/linux/commit/ac73368dea3e89ee63025d4da64dd908bcde367e
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout ac73368dea3e89ee63025d4da64dd908bcde367e
vim +820 drivers/clk/qcom/clk-rcg2.c

ac73368d Taniya Das 2018-05-03 809
ac73368d Taniya Das 2018-05-03 810 /* Common APIs to be used for DFS based RCGR */
ac73368d Taniya Das 2018-05-03 811 static u8 clk_parent_index_pre_div_and_mode(struct clk_hw *hw, u32 offset,
ac73368d Taniya Das 2018-05-03 812 u32 *mode, u32 *pre_div)
ac73368d Taniya Das 2018-05-03 813 {
ac73368d Taniya Das 2018-05-03 814 struct clk_rcg2 *rcg;
ac73368d Taniya Das 2018-05-03 815 int num_parents;
ac73368d Taniya Das 2018-05-03 816 u32 cfg, mask;
ac73368d Taniya Das 2018-05-03 817 int i, ret;
ac73368d Taniya Das 2018-05-03 818
ac73368d Taniya Das 2018-05-03 819 if (!hw)
ac73368d Taniya Das 2018-05-03 @820 return -EINVAL;
ac73368d Taniya Das 2018-05-03 821
ac73368d Taniya Das 2018-05-03 822 num_parents = clk_hw_get_num_parents(hw);
ac73368d Taniya Das 2018-05-03 823
ac73368d Taniya Das 2018-05-03 824 rcg = to_clk_rcg2(hw);
ac73368d Taniya Das 2018-05-03 825
ac73368d Taniya Das 2018-05-03 826 ret = regmap_read(rcg->clkr.regmap, rcg->cmd_rcgr + offset, &cfg);
ac73368d Taniya Das 2018-05-03 827 if (ret)
ac73368d Taniya Das 2018-05-03 828 goto err;
ac73368d Taniya Das 2018-05-03 829
ac73368d Taniya Das 2018-05-03 830 mask = BIT(rcg->hid_width) - 1;
ac73368d Taniya Das 2018-05-03 831 *pre_div = cfg & mask ? (cfg & mask) : 1;
ac73368d Taniya Das 2018-05-03 832
ac73368d Taniya Das 2018-05-03 833 *mode = cfg & CFG_MODE_MASK;
ac73368d Taniya Das 2018-05-03 834 *mode >>= CFG_MODE_SHIFT;
ac73368d Taniya Das 2018-05-03 835
ac73368d Taniya Das 2018-05-03 836 cfg &= CFG_SRC_SEL_MASK;
ac73368d Taniya Das 2018-05-03 837 cfg >>= CFG_SRC_SEL_SHIFT;
ac73368d Taniya Das 2018-05-03 838
ac73368d Taniya Das 2018-05-03 839 for (i = 0; i < num_parents; i++)
ac73368d Taniya Das 2018-05-03 840 if (cfg == rcg->parent_map[i].cfg)
ac73368d Taniya Das 2018-05-03 841 return i;
ac73368d Taniya Das 2018-05-03 842 err:
ac73368d Taniya Das 2018-05-03 843 return 0;
ac73368d Taniya Das 2018-05-03 844 }
ac73368d Taniya Das 2018-05-03 845

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

\
 
 \ /
  Last update: 2018-05-07 10:16    [W:0.074 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site