Messages in this thread | | | Subject | Re: [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN | From | Faiz Abbas <> | Date | Thu, 31 May 2018 22:08:07 +0530 |
| |
Hi,
On Thursday 31 May 2018 07:15 PM, Tony Lindgren wrote: > * Faiz Abbas <faiz_abbas@ti.com> [180531 10:22]: >> On Wednesday 30 May 2018 08:34 PM, Tony Lindgren wrote: >>> Looks good to me except I think the reset won't do anything currently >>> with ti-sysc.c unless you specfify also "ti,hwmods" for the module? >>> >>> Can you please check? It might be worth adding the reset function to >>> ti-sysc.c for non "ti,hwmods" case and that just might remove the >>> need for any hwmod code for this module. >>> >> >> If I understand correctly, this involves adding a (*reset_module) in >> ti_sysc_platform_data and defining a ti_sysc_reset_module() in ti-sysc.c >> similar to ti_sysc_idle_module(). Right? > > Well try moving "ti,hwmods" to the module level first. Then reset will > happen with enable.
Ok. Let me try that.
Thanks, Faiz
| |