lkml.org 
[lkml]   [2018]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] autofs: small cleanup in autofs_getpath()
Dan Carpenter <dan.carpenter@oracle.com> writes:

> We don't set "*name" so it's slightly nicer to just pass "name" instead
> of "&name".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

This seems like an obvious and reasonable cleanup.

> diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c
> index 8c858126c751..f6385c6ef0a5 100644
> --- a/fs/autofs/waitq.c
> +++ b/fs/autofs/waitq.c
> @@ -179,7 +179,7 @@ static void autofs_notify_daemon(struct autofs_sb_info *sbi,
> }
>
> static int autofs_getpath(struct autofs_sb_info *sbi,
> - struct dentry *dentry, char **name)
> + struct dentry *dentry, char *name)
> {
> struct dentry *root = sbi->sb->s_root;
> struct dentry *tmp;
> @@ -189,7 +189,7 @@ static int autofs_getpath(struct autofs_sb_info *sbi,
> unsigned seq;
>
> rename_retry:
> - buf = *name;
> + buf = name;
> len = 0;
>
> seq = read_seqbegin(&rename_lock);
> @@ -395,7 +395,7 @@ int autofs_wait(struct autofs_sb_info *sbi,
> if (IS_ROOT(dentry) && autofs_type_trigger(sbi->type))
> qstr.len = sprintf(name, "%p", dentry);
> else {
> - qstr.len = autofs_getpath(sbi, dentry, &name);
> + qstr.len = autofs_getpath(sbi, dentry, name);
> if (!qstr.len) {
> kfree(name);
> return -ENOENT;

\
 
 \ /
  Last update: 2018-05-31 13:52    [W:0.042 / U:1.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site