Messages in this thread | | | Subject | Re: [PATCH v2 6/7] misc: pci_endpoint_test: Add MSI-X support | From | Kishon Vijay Abraham I <> | Date | Thu, 31 May 2018 16:57:39 +0530 |
| |
Hi,
On Thursday 17 May 2018 10:39 PM, Gustavo Pimentel wrote: > Add MSI-X support and update driver documentation accordingly. > > Add new driver parameter to allow interruption type selection. > > Add 2 new IOCTL commands: > - Allow to reconfigure driver IRQ type in runtime. > - Allow to retrieve current driver IRQ type configured. > > Change Legacy/MSI/MSI-X test process, by having in a BAR: > - Interrupt type triggered (added). > - Interrupt ID number (moved from the command section). > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
It's better to change the subject to pci-epf-test/pci_endpoint_test: Add MSI-X support
IMO this patch should be split into multiple patches
*) Cleanup PCI_ENDPOINT_TEST memspace (by moving the interrupt number away from command section) *) Using irq_type module param *) Adding MSI-X support *) adding 2 ioctl commands (I'm not convinced on adding new ioctls though)
Thanks Kishon
| |