Messages in this thread | | | Date | Thu, 31 May 2018 11:10:22 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks |
| |
On Thu 31-05-18 10:55:32, Michal Hocko wrote: > On Thu 31-05-18 04:35:31, Eric Dumazet wrote: [...] > > I merely copied/pasted from alloc_skb_with_frags() :/ > > I will have a look at it. Thanks!
OK, so this is an example of an incremental development ;).
__GFP_NORETRY was added by ed98df3361f0 ("net: use __GFP_NORETRY for high order allocations") to prevent from OOM killer. Yet this was not enough because fb05e7a89f50 ("net: don't wait for order-3 page allocation") didn't want an excessive reclaim for non-costly orders so it made it completely NOWAIT while it preserved __GFP_NORETRY in place which is now redundant. Should I send a patch?
-- Michal Hocko SUSE Labs
| |