lkml.org 
[lkml]   [2018]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] nvme: provide a way to disable nvme mpath per subsystem
From
Date

> @@ -246,3 +246,27 @@ void nvme_mpath_remove_disk(struct nvme_ns_head *head)
> blk_cleanup_queue(head->disk->queue);
> put_disk(head->disk);
> }
> +
> +int nvme_mpath_change_personality(struct nvme_subsystem *subsys)
> +{
> + struct nvme_ctrl *ctrl;
> + int ret = 0;
> +
> +restart:
> + mutex_lock(&subsys->lock);
> + list_for_each_entry(ctrl, &subsys->ctrls, subsys_entry) {
> + if (!list_empty(&ctrl->namespaces)) {
> + mutex_unlock(&subsys->lock);
> + nvme_remove_namespaces(ctrl);

This looks completely broken. Any of these namespaces can have an
active handle on it.

\
 
 \ /
  Last update: 2018-05-31 10:18    [W:0.148 / U:3.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site