lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V3 3/5 selinux-next] selinux: sidtab_clone switch to use rwlock.
From
Date

>
> +int sidtab_clone(struct sidtab *s, struct sidtab *d)
> +{
> + int i, rc = 0;
If s or d are NULL (see if() below), why would we want rc, the return
value, to be 0?  How about defaulting rc to an error value (-EINVAL)?
> + struct sidtab_node *cur;
> +
> + if (!s || !d)
> + goto errout;
> +
> + read_lock(&s->lock);
> + for (i = 0; i < SIDTAB_SIZE; i++) {
> + cur = s->htable[i];
> + while (cur) {
> + if (cur->sid > SECINITSID_NUM)
> + rc = sidtab_insert(d, cur->sid, &cur->context);
> + if (rc)
> + goto out;
> + cur = cur->next;
> + }
> + }
> +out:
> + read_unlock(&s->lock);
> +errout:
> + return rc;
> +}
>
Thanks,
Jay

\
 
 \ /
  Last update: 2018-05-30 23:23    [W:0.114 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site