lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 038/153] scsi: aacraid: remove redundant setting of variable c
    3.2.102-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit 91814744646351a470f256fbcb853fb5a7229a9f upstream.

    A previous commit no longer stores the contents of c, so we now have a
    situation where c is being updated but the value is never read. Clean up
    the code by removing the now redundant setting of variable c.

    Cleans up clang warning:
    drivers/scsi/aacraid/aachba.c:943:3: warning: Value stored to 'c' is
    never read

    Fixes: f4e8708d3104 ("scsi: aacraid: Fix udev inquiry race condition")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/scsi/aacraid/aachba.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    --- a/drivers/scsi/aacraid/aachba.c
    +++ b/drivers/scsi/aacraid/aachba.c
    @@ -784,11 +784,8 @@ static void setinqstr(struct aac_dev *de
    while (*cp == ' ')
    ++cp;
    /* last six chars reserved for vol type */
    - c = 0;
    - if (strlen(cp) > sizeof(str->pid)) {
    - c = cp[sizeof(str->pid)];
    + if (strlen(cp) > sizeof(str->pid))
    cp[sizeof(str->pid)] = '\0';
    - }
    inqstrcpy (cp, str->pid);

    kfree(cname);
    \
     
     \ /
      Last update: 2018-05-30 13:16    [W:4.102 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site