Messages in this thread | | | Date | Mon, 28 May 2018 21:20:47 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor |
| |
On Thu 24 May 12:21 PDT 2018, Ramon Fried wrote:
> Sometimes that rmtfs userspace module is not brought > up fast enough and the modem crashes. > disabling automated boot in the driver and triggering > the boot from user-space sovles the problem. > > Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Thanks for your patch Ramon. While this nudges the behavior to make things work slightly better I think we need to describe the explicit dependency between the mss firmware and the existence of rmtfs.
As our remoteprocs are essentially always-on I would prefer that they start "automatically" and not through use of the sysfs interface.
But we're at the point where this is a real problem on 410, 820 and 845, so we have to come up with some way to tie these pieces together. If your patch suits that solution I will happily take it.
Regards, Bjorn
> --- > drivers/remoteproc/qcom_q6v5_pil.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c > index cbbafdcaaecb..719ee96445b3 100644 > --- a/drivers/remoteproc/qcom_q6v5_pil.c > +++ b/drivers/remoteproc/qcom_q6v5_pil.c > @@ -1133,6 +1133,8 @@ static int q6v5_probe(struct platform_device *pdev) > return -ENOMEM; > } > > + rproc->auto_boot = false; > + > qproc = (struct q6v5 *)rproc->priv; > qproc->dev = &pdev->dev; > qproc->rproc = rproc; > -- > 2.17.0 >
| |