Messages in this thread | | | From | Yafang Shao <> | Date | Tue, 29 May 2018 19:08:58 +0800 | Subject | Re: [PATCH v3 net-next 2/2] tcp: minor optimization around tcp_hdr() usage in tcp receive path |
| |
On Tue, May 29, 2018 at 12:53 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > > > On 05/28/2018 05:41 PM, Yafang Shao wrote: > >> OK. >> >> And what about introducing a new helper tcp_hdr_fast() ? >> >> /* use it when tcp header has not been pulled yet */ >> static inline struct tcphdr *tcp_hdr_fast(const struct sk_buff *skb) >> >> { >> >> return (const struct tcphdr *)skb->data; >> >> } >> >> >> That could help us to use this optimized one instead of the original >> one if possilbe. > > > I would rather not add such macro... > > The call site needs to know what is going on, so having a macro like that would not help.
OK
| |